lkml.org 
[lkml]   [2009]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/7] mtrr: Remove use_intel()
From
On Wed, Dec 9, 2009 at 12:52 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
>> can you check it with amd64 cpu?
>
> do you have a suspicion that it might be broken?

void __init mtrr_bp_init(void)
{
u32 phys_addr;

init_ifs();

phys_addr = 32;

if (cpu_has_mtrr) {
mtrr_if = &generic_mtrr_ops;
size_or_mask = 0xff000000; /* 36 bits */
size_and_mask = 0x00f00000;
phys_addr = 36;

and in generic_mtrr_ops
/*
* Generic structure...
*/
struct mtrr_ops generic_mtrr_ops = {
.use_intel_if = 1,
.set_all = generic_set_all,

so all cpus that cpuid tell us that there is mtrr support, will all
have use_intel() == 1

YH


\
 
 \ /
  Last update: 2009-12-09 19:35    [W:0.059 / U:5.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site