Messages in this thread | | | Date | Wed, 9 Dec 2009 07:05:38 +0100 | From | Ingo Molnar <> | Subject | Re: x86: ucode-amd: Convert printk(KERN_*...) to pr_*(...) |
| |
* Joe Perches <joe@perches.com> wrote:
> On Tue, 2009-12-08 at 22:59 +0000, Linux Kernel Mailing List wrote: > > Commit: 1a74357066369be91e6f4f431621a00b052df964 > > diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c > > index 9f13324..26e33bd 100644 > > --- a/arch/x86/kernel/microcode_amd.c > > +++ b/arch/x86/kernel/microcode_amd.c > [] > > @@ -113,7 +113,7 @@ static int get_matching_microcode(int cpu, void *mc, int rev) > > > > /* ucode might be chipset specific -- currently we don't support this */ > > if (mc_header->nb_dev_id || mc_header->sb_dev_id) { > > - printk(KERN_ERR "microcode: CPU%d: loading of chipset " > > + pr_err(KERN_ERR "microcode: CPU%d: loading of chipset " > > "specific code not yet supported\n", cpu); > > return 0; > > } > > Duplicates KERN_ERR
Indeed - please send a delta fix as this has been merged already.
( Andy: i suspect checkpatch could also grow a new warning perhaps, the '\<pr_.*(KERN_.*' pattern will i suspect pinpoint something fishy in most cases. )
Ingo
| |