Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH v3] [RFC] tracepoint: Add signal coredump tracepoint | Date | Wed, 9 Dec 2009 14:34:46 +0900 (JST) |
| |
> + TP_fast_assign( > + __entry->sig = (int)cprm->signr; > + __entry->limit = cprm->limit; > + __entry->flags = cprm->mm_flags; > + __entry->retval = retval; > + __assign_str(name, core_name); > + ), > + > + TP_printk("sig=%d limit=%lu dumpable=0x%lx dump_filter=0x%lx " > + "corename=\"%s\" retval=%d", > + __entry->sig, __entry->limit, > + __entry->flags & MMF_DUMPABLE_MASK, > + (__entry->flags & MMF_DUMP_FILTER_MASK) >> > + MMF_DUMP_FILTER_SHIFT, > + __get_str(name), __entry->retval) > +); > #endif /* _TRACE_SIGNAL_H */
I don't think "limit" is userfriendly name, core_limit or core_size_limit is better? plus, we have core_pipe_limit sysctl too. (it's similar but different concept limit).
other parts looks good to me.
| |