lkml.org 
[lkml]   [2009]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] [RFC] tracepoint: Add signal coredump tracepoint
Date
> +	TP_fast_assign(
> + __entry->sig = (int)cprm->signr;
> + __entry->limit = cprm->limit;
> + __entry->flags = cprm->mm_flags;
> + __entry->retval = retval;
> + __assign_str(name, core_name);
> + ),
> +
> + TP_printk("sig=%d limit=%lu dumpable=0x%lx dump_filter=0x%lx "
> + "corename=\"%s\" retval=%d",
> + __entry->sig, __entry->limit,
> + __entry->flags & MMF_DUMPABLE_MASK,
> + (__entry->flags & MMF_DUMP_FILTER_MASK) >>
> + MMF_DUMP_FILTER_SHIFT,
> + __get_str(name), __entry->retval)
> +);
> #endif /* _TRACE_SIGNAL_H */

I don't think "limit" is userfriendly name, core_limit or core_size_limit is better?
plus, we have core_pipe_limit sysctl too. (it's similar but different concept limit).

other parts looks good to me.





\
 
 \ /
  Last update: 2009-12-09 06:37    [W:0.192 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site