Messages in this thread | | | Date | Tue, 8 Dec 2009 09:20:44 +0100 (CET) | From | Guennadi Liakhovetski <> | Subject | Re: [PATCH 4/5] sh: stylistic improvements for the DMA driver |
| |
On Mon, 7 Dec 2009, Dan Williams wrote:
> On Fri, Dec 4, 2009 at 11:45 AM, Guennadi Liakhovetski > <g.liakhovetski@gmx.de> wrote: > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > --- > > drivers/dma/shdma.c | 34 +++++++++++++++++----------------- > > drivers/dma/shdma.h | 14 +++++++------- > > 2 files changed, 24 insertions(+), 24 deletions(-) > > > [..] > > -static int dmae_is_idle(struct sh_dmae_chan *sh_chan) > > +static int dmae_is_busy(struct sh_dmae_chan *sh_chan) > > This one isn't purely style, I agree with it, but think it would be a > bit cleaner to return a bool rather than an error code.
Yes, I also thought about it, but I wasn't sure whether the author had some special considerations, why he has chosen to return an error code. Besides, that return code is also used in functions dmae_set_chcr() and dmae_set_dmars() as their return value. So, you'd have to change those two to something like
if (dmae_is_busy(sh_chan)) return -EBUSY;
Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |