lkml.org 
[lkml]   [2009]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/13] tracing: Extract duplicate ftrace_raw_init_event_foo()
>> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
>> index e79e2f3..55e7108 100644
>> --- a/include/linux/syscalls.h
>> +++ b/include/linux/syscalls.h
>> @@ -144,7 +144,7 @@ struct perf_event_attr;
>> .name = "sys_enter"#sname, \
>> .system = "syscalls", \
>> .event = &enter_syscall_print_##sname, \
>> - .raw_init = init_syscall_trace, \
>> + .raw_init = trace_event_raw_init, \
>> .show_format = syscall_enter_format, \
>> .define_fields = syscall_enter_define_fields, \
>> .regfunc = reg_event_syscall_enter, \
>> @@ -166,7 +166,7 @@ struct perf_event_attr;
>> .name = "sys_exit"#sname, \
>> .system = "syscalls", \
>> .event = &exit_syscall_print_##sname, \
>> - .raw_init = init_syscall_trace, \
>> + .raw_init = trace_event_raw_init, \
>
>
>
> Nice cleanup.
> BTW, init_syscall_trace is left unused now. Could you please
> remove it too?
>

I'd like to see the whole patchset be accepted first. I don't
won't to spam LKML with another 14 emails. ;)

Though I can just resend this patch, Ingo might be confused
which patch he should take.

btw, Lai Jiangshan just told me he has a pending patch that
will modify init_syscall_trace, so init_syscall_trace will
come back to use again.

> And add my Acked-by. Thanks!
>

Thanks!


\
 
 \ /
  Last update: 2009-12-08 08:53    [from the cache]
©2003-2011 Jasper Spaans