lkml.org 
[lkml]   [2009]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/13] tracing: Move a printk out of ftrace_raw_reg_event_foo()
>> -static void ftrace_event_enable_disable(struct ftrace_event_call *call,
>> +static int ftrace_event_enable_disable(struct ftrace_event_call *call,
>> int enable)
>> {
>> + int ret = 0;
>> +
>> switch (enable) {
>> case 0:
>> if (call->enabled) {
>> @@ -131,12 +133,19 @@ static void ftrace_event_enable_disable(struct ftrace_event_call *call,
>> break;
>> case 1:
>> if (!call->enabled) {
>> + ret = call->regfunc(call);
>> + if (ret) {
>> + pr_info("event trace: Could not enable event "
>> + "%s\n", call->name);
>> + break;
>> + }
>> call->enabled = 1;
>> tracing_start_cmdline_record();
>> - call->regfunc(call);
>
> That seems to open a tiny window during which we'll lose
> some pid -> comm resolution records.
>
> We should probably keep the previous call order.
>

Hm, actually the tiny window is already there in that
tracing_stop_cmdline_record() is called before call->unregfunc()..

So I can send a fix-up patch later.

> Other than that:
>
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
>

Thanks.


\
 
 \ /
  Last update: 2009-12-08 08:53    [W:0.063 / U:32.224 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site