lkml.org 
[lkml]   [2009]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [12/31] HWPOISON: remove the free buddy page handler
    Date

    From: Wu Fengguang <fengguang.wu@intel.com>

    The buddy page has already be handled in the very beginning.
    So remove redundant code.

    Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    mm/memory-failure.c | 14 ++++----------
    1 file changed, 4 insertions(+), 10 deletions(-)

    Index: linux/mm/memory-failure.c
    ===================================================================
    --- linux.orig/mm/memory-failure.c
    +++ linux/mm/memory-failure.c
    @@ -401,14 +401,6 @@ static int me_unknown(struct page *p, un
    }

    /*
    - * Free memory
    - */
    -static int me_free(struct page *p, unsigned long pfn)
    -{
    - return DELAYED;
    -}
    -
    -/*
    * Clean (or cleaned) page cache page.
    */
    static int me_pagecache_clean(struct page *p, unsigned long pfn)
    @@ -604,7 +596,6 @@ static int me_huge_page(struct page *p,
    #define tail (1UL << PG_tail)
    #define compound (1UL << PG_compound)
    #define slab (1UL << PG_slab)
    -#define buddy (1UL << PG_buddy)
    #define reserved (1UL << PG_reserved)

    static struct page_state {
    @@ -614,7 +605,10 @@ static struct page_state {
    int (*action)(struct page *p, unsigned long pfn);
    } error_states[] = {
    { reserved, reserved, "reserved kernel", me_ignore },
    - { buddy, buddy, "free kernel", me_free },
    + /*
    + * free pages are specially detected outside this table:
    + * PG_buddy pages only make a small fraction of all free pages.
    + */

    /*
    * Could in theory check if slab page is free or if we can drop

    \
     
     \ /
      Last update: 2009-12-08 22:25    [W:0.046 / U:0.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site