lkml.org 
[lkml]   [2009]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/5] spi-imx: correct check for platform_get_irq failing
    Date
    platform_get_irq returns -ENXIO if there is no entry.  So don't check
    return value being nonzero but greater or equal to zero.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: David Brownell <dbrownell@users.sourceforge.net>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Sascha Hauer <s.hauer@pengutronix.de>
    ---
    drivers/spi/spi_imx.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c
    index c83ca05..d8d9a35 100644
    --- a/drivers/spi/spi_imx.c
    +++ b/drivers/spi/spi_imx.c
    @@ -554,7 +554,7 @@ static int __init spi_imx_probe(struct platform_device *pdev)
    }

    spi_imx->irq = platform_get_irq(pdev, 0);
    - if (!spi_imx->irq) {
    + if (spi_imx->irq < 0) {
    ret = -EINVAL;
    goto out_iounmap;
    }
    --
    1.6.5.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-08 22:17    [W:0.021 / U:159.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site