Messages in this thread | | | From | Arkadiusz Miskiewicz <> | Subject | Re: [PATCH] MAINTAINERS: new kbuild maintainer | Date | Tue, 8 Dec 2009 21:07:19 +0100 |
| |
On Tuesday 08 of December 2009, Michal Marek wrote: > Arkadiusz Miskiewicz napsal(a): > > On Tuesday 08 of December 2009, Sam Ravnborg wrote: > >> On Tue, Dec 08, 2009 at 01:52:31PM +0100, Michal Marek wrote: > >>> Sam was fine with handing over kbuild maintainership to me. The git > >>> trees are already in linux-next, a merge request will follow shortly. > >> > >> Yep - thanks for taken over this. Glad to see this is maintained > >> properly. > > > > Maybe we can get colors back in menuconfig then? ;-) > > http://bugzilla.kernel.org/show_bug.cgi?id=13677 > > Does it also happen with Nir's nconfig > (http://lkml.org/lkml/2009/11/25/119)?
Yes, it does happen, I have non-color menus. That's because nconfig also mixes wide ncurses library with non wide ncurses headers.
gcc -Wp,-MD,scripts/kconfig/.nconf.o.d -Wall -Wmissing-prototypes -Wstrict- prototypes -O2 -fomit-frame-pointer -I/usr/include/ncurses - DCURSES_LOC="<ncurses.h>" -DLOCALE -c -o scripts/kconfig/nconf.o scripts/kconfig/nconf.c
/usr/include/ncurses is non wide version of ncurses headers (but on other distros it could be done differently aka /usr/include/ncures being wide version)
gcc -o scripts/kconfig/nconf scripts/kconfig/nconf.o scripts/kconfig/zconf.tab.o scripts/kconfig/nconf.gui.o -lncursesw -lmenu - lpanel -lncurses
and here it's linked to non wide version of library (also to wide, too due to scripts/kconfig/lxdialog/check-lxdialog.sh putting it here)
Anyway way to solve this is: - detect if ncurses header is wide or non-wide - link with proper ncurses library based on detected header
> Michal
-- Arkadiusz Miśkiewicz PLD/Linux Team arekm / maven.pl http://ftp.pld-linux.org/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |