lkml.org 
[lkml]   [2009]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver

> > What is going on here? I thought the value is already in two's
> > complement... Is the above equivalent of
> >
> > if (value < 0)
> > value = -value;
> >
> > ? If so, why? If not, can you add a comment?
>
> Right, then, will use this instead:
>
> static int get_battery_current(void)
> {
> s16 value;
>
> value = (ec_read(REG_BAT_CURRENT_HIGH) << 8) |
> (ec_read(REG_BAT_CURRENT_LOW));
>
> return abs(value);
> }

That's certainly better. But... why not return signed value? Current
flowing from the battery is certainly very different from current
flowing into it...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-12-07 09:07    [W:0.048 / U:45.632 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site