lkml.org 
[lkml]   [2009]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing - fix function graph trace to properly display failed entries
On Fri, Dec 04, 2009 at 11:46:16AM +0100, Jiri Olsa wrote:
> > sure, but it is not the trace_seq structure that overflows, it is the bare
> > seq_file underneath. The s_show calls "trace_print_seq":
> >
> > void trace_print_seq(struct seq_file *m, struct trace_seq *s)
> > {
> > int len = s->len >= PAGE_SIZE ? PAGE_SIZE - 1 : s->len;
> >
> > seq_write(m, s->buffer, len);
> >
> > trace_seq_init(s);
> > }
> >
> > it flushes the trace_seq to the seq_file and reinits the trace_seq.
> > But the seq_file will get filled in the end, ending up with
> > not displayed output in that case I described in the first email.
> >
>
> hi, any feedback on this?
>
> thanks,
> jirka


Steven has done some tests and it looks like you were right, the
problem comes from the seq_file, not the trace_seq.

Steve, any news about it?

Thanks.



\
 
 \ /
  Last update: 2009-12-07 21:25    [W:0.086 / U:14.072 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site