[lkml]   [2009]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [GIT PULL] PM updates for 2.6.33

    On Mon, 7 Dec 2009, Rafael J. Wysocki wrote:
    > > The advantage: untouched drivers don't change ANY SEMANTICS AT ALL.
    > This also was true for my patchset.

    That's simply not trye.

    You set async_suspend on every single PCI driver. I object very heavily to

    You also introduce this whole big "callback when ready", and
    "non-topoligical PM dependency chain" thing. Which I also object to.

    Notice how with the simpler "lock parent" model, you _can_ actually encode
    non-topological dependencies, but you do it by simply read-locking
    whatever other independent device you want. So if an architecture has some
    system devices that have odd rules, that architecture can simply encode
    those rules in its suspend() functions.

    It doesn't need to expose it to the device layer - because the device
    layer won't even care. The code will just automatically "do the right
    thing" without even having that notion of PM dependencies at any other
    level than the driver that knows about it.

    No registration, no callbacks, no nothing.

    > In my patchset the drivers didn't need to do all that stuff. The only thing
    > they needed, if they wanted their suspend/resume to be executed
    > asynchronously, was to set the async_suspend flag.

    In my patchset, the drivers don't need to either.

    The _only_ thing that would do this is something like the USB layer. We're
    talking ten lines of code or so. And you get rid of all the PM
    dependencies and all the infrastructure - because the model is so simple
    that it doesn't need any.

    (Well, except for the infrastructure to run things asynchronously, but
    that was kind of my point from the very beginning: we can just re-use all
    that existing async infrastructure. We already have that).


     \ /
      Last update: 2009-12-07 17:41    [W:0.021 / U:20.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site