lkml.org 
[lkml]   [2009]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open()
On Mon, 07 Dec 2009 14:33:39 +0100
Roel Kluin <roel.kluin@gmail.com> wrote:

> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/s390/char/fs3270.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c
> index 097d384..2ae58d0 100644
> --- a/drivers/s390/char/fs3270.c
> +++ b/drivers/s390/char/fs3270.c
> @@ -465,7 +465,7 @@ fs3270_open(struct inode *inode, struct file *filp)
> if (IS_ERR(ib)) {
> raw3270_put_view(&fp->view);
> raw3270_del_view(&fp->view);
> - rc = PTR_ERR(fp);
> + rc = PTR_ERR(ib);
> goto out;
> }
> fp->rdbuf = ib;

And added this one as well.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.



\
 
 \ /
  Last update: 2009-12-07 15:07    [W:0.026 / U:42.228 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site