lkml.org 
[lkml]   [2009]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] proc: fill 'lib' field in /proc/<pid>/statm
Hugh Dickins wrote:
> On Mon, 7 Dec 2009, Amerigo Wang wrote:
>
>> Currently, the 'lib' field of /proc/<pid>/statm is
>> always 0, we should fill it with the right value,
>> the same with 'VmLib'.
>
> The right value (if you're looking for consistency with Linux 2.4)
> is the number of currently resident "library" pages: and we don't
> know that number - we can't even define what a library is.

Hmm, the current algorithm is just kicking out text size of itself
from ->exec_vm, it really makes some sense, but not always.

>
> We could add some code to make it show the same bogus number as
> we show somewhere else, but it has said 0 ever since 2.5.37: so
> I don't think it's worth a line of code myself, but bow to others.


If you mean 'VmLib' in /proc/<pid>/status, this is the same with it.

>
>> Signed-off-by: WANG Cong <amwang@redhat.com>
>> Cc: Eric W. Biederman <ebiederm@xmission.com>
>> Cc: Alexey Dobriyan <adobriyan@gmail.com>
>> Cc: Al Viro <viro@zeniv.linux.org.uk>
>> Cc: Mel Gorman <mel@csn.ul.ie>
>> Cc: stable@kernel.org
>
> What does alarm me is that you think this is fit for -stable!
>

Oh, sorry, I thought missing this field is a mistake...
Dropped.

Thanks.


\
 
 \ /
  Last update: 2009-12-07 12:43    [W:0.041 / U:23.784 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site