Messages in this thread | | | Date | Mon, 7 Dec 2009 06:38:06 +0100 | From | Ingo Molnar <> | Subject | Re: [RFC] print symbolic page flag names in bad_page() |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> > So how about this patch? > > I like it. Decoding the flags by hand is always a very unpleasant > experience. Bonus: dump_page can be called from kgdb too.
Guys, please do more review:
> +void dump_page(struct page *page) > +{ > + char buf[1024];
NAK. This code causes a brutal, +1K kernel stack footprint spike that can crash a system _precisely_ when we are trying to dump a (presumably rare) condition.
> +EXPORT_SYMBOL(dump_page);
( Small detail: such exports are EXPORT_SYMBOL_GPL - we dont want random external modules start using it. )
Thanks,
Ingo
| |