lkml.org 
[lkml]   [2009]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: manual merge of the pcmcia tree with the pxa tree
On Mon, 30 Nov 2009 09:48:13 +0000
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

Hi Russell,

> What would be a better idea is to rework the driver once my changes
> have hit. If you need to pass additional data around, you can do it
> like this:

Now that your changes are in Linus' tree, I started looking at
restructuring my code. I sense a small problem though:

[...]
> for (i = 0; i < nr; i++) {
> skts[i].skt.nr = i;
> skts[i].skt.ops = &my_ops;
> skts[i].skt.socket.owner = THIS_MODULE;
> skts[i].skt.socket.parent = &dev->dev;
> skts[i].skt.socket.pci_irq = the_socket_irq;
> ret = pxa2xx_drv_pcmcia_add_one(&skts[i].skt);

Unless I'm mistaken, it seems that pxa2xx_drv_pcmcia_add_one() doesn't
call pxa2xx_configure_sockets(), leaving the sockets disabled.

There is several ways to solve this one:
- Add the call to pxa2xx_configure_sockets() to _add_one()
- Do the MECR access in the pxa2xx_viper driver,
- export pxa2xx_configure_sockets() and do the call locally.

What would be your preferred solution?

M.
--
I'm the slime oozin' out from your TV set...


\
 
 \ /
  Last update: 2009-12-06 10:53    [W:0.037 / U:18.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site