lkml.org 
[lkml]   [2009]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[099/119] hwmon: (adt7475) Fix temperature fault flags
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Jean Delvare <khali@linux-fr.org>

    commit cf312e077662ec3a07529551ab6e885828ccfb1d upstream.

    The logic of temperature fault flags is wrong, it shows faults when
    there are none and vice versa. Fix it.

    I can't believe this has been broken since the driver was added, 8
    months ago, basically breaking temp1 and temp3, and nobody ever
    complained.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Acked-by: Hans de Goede <hdegoede@redhat.com>
    Cc: Jordan Crouse <jordan@cosmicpenguin.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/hwmon/adt7475.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/hwmon/adt7475.c
    +++ b/drivers/hwmon/adt7475.c
    @@ -350,8 +350,7 @@ static ssize_t show_temp(struct device *

    case FAULT:
    /* Note - only for remote1 and remote2 */
    - out = data->alarms & (sattr->index ? 0x8000 : 0x4000);
    - out = out ? 0 : 1;
    + out = !!(data->alarms & (sattr->index ? 0x8000 : 0x4000));
    break;

    default:



    \
     
     \ /
      Last update: 2009-12-07 01:25    [W:0.023 / U:0.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site