lkml.org 
[lkml]   [2009]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[054/119] ASoC: AIC23: Fixing infinite loop in resume path
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Anuj Aggarwal <anuj.aggarwal@ti.com>

    commit e9ff5eb2ae018fe2298c68746c873bf828c6b10e upstream.

    This patch fixes two issues:
    a) Infinite loop in resume function
    b) Writes to non-existing registers in resume function

    Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
    Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    sound/soc/codecs/tlv320aic23.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/sound/soc/codecs/tlv320aic23.c
    +++ b/sound/soc/codecs/tlv320aic23.c
    @@ -625,11 +625,10 @@ static int tlv320aic23_resume(struct pla
    {
    struct snd_soc_device *socdev = platform_get_drvdata(pdev);
    struct snd_soc_codec *codec = socdev->card->codec;
    - int i;
    u16 reg;

    /* Sync reg_cache with the hardware */
    - for (reg = 0; reg < ARRAY_SIZE(tlv320aic23_reg); i++) {
    + for (reg = 0; reg < TLV320AIC23_RESET; reg++) {
    u16 val = tlv320aic23_read_reg_cache(codec, reg);
    tlv320aic23_write(codec, reg, val);
    }



    \
     
     \ /
      Last update: 2009-12-07 01:19    [W:0.021 / U:31.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site