lkml.org 
[lkml]   [2009]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [stable] x86: Remove STACKPROTECTOR_ALL
Greg KH skrev:
> On Wed, Nov 11, 2009 at 12:23:16AM +0200, Thomas Backlund wrote:
>> I think this one should go to 2.6.31.x too ...
>>
>>> Gitweb: http://git.kernel.org/linus/14a3f40aafacde1dfd6912327ae14df4baf10304
>>> Commit: 14a3f40aafacde1dfd6912327ae14df4baf10304
>>> Parent: 02dd0a0613e0d84c7dd8315e3fe6204d005b7c79
>>> Author: Arjan van de Ven <arjan@infradead.org>
>>> AuthorDate: Fri Oct 23 07:31:01 2009 -0700
>>> Committer: Ingo Molnar <mingo@elte.hu>
>>> CommitDate: Fri Oct 23 16:35:23 2009 +0200
>>>
>>> x86: Remove STACKPROTECTOR_ALL
>>>
>>> STACKPROTECTOR_ALL has a really high overhead (runtime and stack
>>> footprint) and is not really worth it protection wise (the
>>> normal STACKPROTECTOR is in effect for all functions with
>>> buffers already), so lets just remove the option entirely.
>>>
>>> Reported-by: Dave Jones <davej@redhat.com>
>>> Reported-by: Chuck Ebbert <cebbert@redhat.com>
>>> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
>>> Cc: Eric Sandeen <sandeen@redhat.com>
>>> LKML-Reference: <20091023073101.3dce4ebb@infradead.org>
>>> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
> It doesn't really "fix" anything, so I'd prefer not too.
>

The reason for I suggested it was that is's supposed to remove some
bloating, and reportedly xfs from blowing up:

http://marc.info/?l=linux-kernel&m=125614028227106&w=2

But anyway, it's your call...

--
Thomas



\
 
 \ /
  Last update: 2009-12-07 00:53    [W:0.038 / U:0.956 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site