lkml.org 
[lkml]   [2009]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH -next resend/fixed] media/miro: fix kconfig depends/select
    From: Randy Dunlap <randy.dunlap@oracle.com>

    miropcm20 uses ALSA (snd_) interfaces from the SND_MIRO
    driver, so it should depend on SND.
    (selecting SND_MIRO when CONFIG_SND is not enabled is a
    problem.)

    drivers/built-in.o: In function `vidioc_s_ctrl':
    radio-miropcm20.c:(.text+0x227499): undefined reference to `snd_aci_cmd'
    drivers/built-in.o: In function `vidioc_s_frequency':
    radio-miropcm20.c:(.text+0x227574): undefined reference to `snd_aci_cmd'
    radio-miropcm20.c:(.text+0x227588): undefined reference to `snd_aci_cmd'
    drivers/built-in.o: In function `pcm20_init':
    radio-miropcm20.c:(.init.text+0x2a784): undefined reference to `snd_aci_get_aci'

    miropcm20 selects SND_MIRO but SND_ISA may be not enabled, so
    also select SND_ISA so that the snd-miro driver will be built.
    Otherwise there are missing symbols:

    ERROR: "snd_opl4_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
    ERROR: "snd_wss_pcm" [sound/isa/opti9xx/snd-miro.ko] undefined!
    ERROR: "snd_wss_timer" [sound/isa/opti9xx/snd-miro.ko] undefined!
    ERROR: "snd_wss_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
    ERROR: "snd_wss_mixer" [sound/isa/opti9xx/snd-miro.ko] undefined!

    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    ---
    drivers/media/radio/Kconfig | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- linux-next-20091204.orig/drivers/media/radio/Kconfig
    +++ linux-next-20091204/drivers/media/radio/Kconfig
    @@ -197,7 +197,8 @@ config RADIO_MAESTRO

    config RADIO_MIROPCM20
    tristate "miroSOUND PCM20 radio"
    - depends on ISA && VIDEO_V4L2
    + depends on ISA && VIDEO_V4L2 && SND
    + select SND_ISA
    select SND_MIRO
    ---help---
    Choose Y here if you have this FM radio card. You also need to enable

    \
     
     \ /
      Last update: 2009-12-06 20:11    [W:0.044 / U:59.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site