lkml.org 
[lkml]   [2009]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC][PATCH] sched: fix GENTLE_FAIR_SLEEPERS dependency
    From
    Date
    On Fri, 2009-12-04 at 14:59 +0530, Suresh Jayaraman wrote:
    > The newly introduced GENTLE_FAIR_SLEEPERS does not seem to have any
    > effect without FAIR_SLEEPERS. Fix sysctl.sched_features to reflect
    > this. Without this change, a user who sets GENTLE_FAIR_SLEEPERS
    > without FAIR_SLEEPERS would assume gentle sleeper fairness which
    > is not guaranteed.

    IMHO, these dependencies belong in documentation, not enforcement code.

    Same applies for LAST_BUDDY, meaningless without WAKEUP_PREEMPT.
    SYNC_MORE, SYNC_LESS + AFFINE_WAKEUPS etc.

    Bottom line for all button poking and knob turning is you'd better make
    sure you know what button/knob does, and what other things may depend on
    it before messing with it, lest you get a nasty surprise.

    -Mike



    \
     
     \ /
      Last update: 2009-12-04 11:09    [W:0.020 / U:5.580 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site