Messages in this thread | | | Date | Fri, 4 Dec 2009 21:37:47 -0700 | From | Alex Chiang <> | Subject | Re: [PATCH] pci: Make pci_dev struct point to NULL. |
| |
* Alex Chiang <achiang@hp.com>: > * Rakib Mullick <rakib.mullick@gmail.com>: > > On 12/5/09, Alex Chiang <achiang@hp.com> wrote: > > > * Rakib Mullick <rakib.mullick@gmail.com>: > > > > > > This is from Linus's latest tree: > > > > > > 974 > > > 975 if (slot->flags & SLOT_ENABLED) > > > 976 goto err_exit; > > > > I'm talking about this line. From here we can hit 'goto err_exit' without > > using pci_get_slot. > > Right, so what's the problem? If the slot is not enabled, we goto > err_exit and return, never touching dev.
Whoops, of course I meant if the slot is already enabled, then we return early.
/ac
| |