lkml.org 
[lkml]   [2009]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci: Make pci_dev struct point to NULL.
* Alex Chiang <achiang@hp.com>:
> * Rakib Mullick <rakib.mullick@gmail.com>:
> > On 12/5/09, Alex Chiang <achiang@hp.com> wrote:
> > > * Rakib Mullick <rakib.mullick@gmail.com>:
> > >
> > > This is from Linus's latest tree:
> > >
> > > 974
> > > 975 if (slot->flags & SLOT_ENABLED)
> > > 976 goto err_exit;
> >
> > I'm talking about this line. From here we can hit 'goto err_exit' without
> > using pci_get_slot.
>
> Right, so what's the problem? If the slot is not enabled, we goto
> err_exit and return, never touching dev.

Whoops, of course I meant if the slot is already enabled, then we
return early.

/ac



\
 
 \ /
  Last update: 2009-12-05 05:39    [W:0.091 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site