lkml.org 
[lkml]   [2009]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/31] Constify struct e1000_mac_operations for 2.6.32 v1
Stephen Rothwell wrote:
> Hi Emese,
>
> On Sat, 05 Dec 2009 01:03:03 +0100 Emese Revfy <re.emese@gmail.com> wrote:
>> --- a/drivers/net/e1000e/82571.c
>> +++ b/drivers/net/e1000e/82571.c
>> @@ -212,6 +212,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter)
>> {
>> struct e1000_hw *hw = &adapter->hw;
>> struct e1000_mac_info *mac = &hw->mac;
>> + /* cannot be const */
>> struct e1000_mac_operations *func = &mac->ops;
>
> Adding to the comment to say why it can't be const may allow us to fix
> this later ...

Ok, in the next patch series I will explain each case.


\
 
 \ /
  Last update: 2009-12-05 02:19    [W:0.075 / U:1.532 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site