| Date | Fri, 4 Dec 2009 17:08:45 -0700 | | From | Matthew Wilcox <> | | Subject | Re: [PATCH 02/31] Constify struct address_space_operations for 2.6.32 v1 |
| |
On Fri, Dec 04, 2009 at 11:08:09PM +0100, Emese Revfy wrote: > struct address_space_operations { > - int (*writepage)(struct page *page, struct writeback_control *wbc); > - int (*readpage)(struct file *, struct page *); > - void (*sync_page)(struct page *); > + int (* const writepage)(struct page *page, struct writeback_control *wbc); > + int (* const readpage)(struct file *, struct page *); > + void (* const sync_page)(struct page *);
Umm. What effect does this have? Aren't functions implicitly constant? What changes as a result of this patch?
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
|