lkml.org 
[lkml]   [2009]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 08/15] ima: valid return code from ima_inode_alloc
    Date
    ima_inode_alloc returns 0 and 1, but the LSM hooks expects an errno.

    Signed-off-by: Eric Paris <eparis@redhat.com>
    ---

    security/integrity/ima/ima_iint.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/security/integrity/ima/ima_iint.c b/security/integrity/ima/ima_iint.c
    index a4e2b1d..4a53f39 100644
    --- a/security/integrity/ima/ima_iint.c
    +++ b/security/integrity/ima/ima_iint.c
    @@ -87,8 +87,6 @@ out:
    /**
    * ima_inode_alloc - allocate an iint associated with an inode
    * @inode: pointer to the inode
    - *
    - * Return 0 on success, 1 on failure.
    */
    int ima_inode_alloc(struct inode *inode)
    {
    @@ -99,7 +97,7 @@ int ima_inode_alloc(struct inode *inode)

    iint = ima_iint_insert(inode);
    if (!iint)
    - return 1;
    + return -ENOMEM;
    return 0;
    }



    \
     
     \ /
      Last update: 2009-12-04 21:53    [W:2.309 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site