Messages in this thread | | | Subject | Re: [PATCH] proc: revert to show stack information in /proc/{pid}/status | From | Stefani Seibold <> | Date | Thu, 31 Dec 2009 16:48:14 +0100 |
| |
Am Donnerstag, den 31.12.2009, 23:12 +0900 schrieb KOSAKI Motohiro: > Commit d899bf7b (procfs: provide stack information for threads) introduced > to show stack information in /proc/{pid}/status. But it cause large performance > regression. Unfortunately /proc/{pid}/status is used ps command too and ps is > one of most important component. Because both to take mmap_sem and page table walk > are heavily operation. >
/proc/<pid>/status is IMHO not a performance relevant thing. The main reason is to provide exact information about a running process.
> Thus, this patch revert it. Fortunately /proc/{pid}/task/{tid}/smaps > provide almost same information. we can use it. >
Completely wrong. Where does smaps provides this kind of information? Where is there the high water mark of the stack usage?
> Cc: Stefani Seibold <stefani@seibold.net> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Alexey Dobriyan <adobriyan@gmail.com> > Cc: "Eric W. Biederman" <ebiederm@xmission.com> > Cc: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > ---
Nak: Stefani Seibold <stefani@seibold.net>
| |