lkml.org 
[lkml]   [2009]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: tty: &&/|| confusion in mxser_get_ISA_conf()?
On 12/31/2009 01:03 PM, Roel Kluin wrote:
> vi drivers/char/mxser.c +2460 and note:
>
> if ((irq != regs[9]) || (irq != regs[10]))
>
> Should this be an && ?

I would say not. It's a check whether irq is the same for all chips. It
jumps to a true branch iff at least one irq of the 8 is different (there
are 4 in each register). Does it make sense?

--
js


\
 
 \ /
  Last update: 2009-12-31 13:41    [W:0.523 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site