Messages in this thread | | | Date | Fri, 4 Dec 2009 08:35:49 +0800 | Subject | Re: [PATCH 3/3] fb-defio: Inhibit VM_IO flag to be set on vmalloc-ed framebuffers. | From | Jaya Kumar <> |
| |
On Thu, Dec 3, 2009 at 11:31 PM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > The framebuffers (screenbase) these drivers present are actually > vmalloc-ed pages. There is no need for them to have the VM_IO flag set. > --- > drivers/video/broadsheetfb.c | 2 +- > drivers/video/hecubafb.c | 2 +- > drivers/video/metronomefb.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c > index 509cb92..df9ccb9 100644 > --- a/drivers/video/broadsheetfb.c > +++ b/drivers/video/broadsheetfb.c > @@ -470,7 +470,7 @@ static int __devinit broadsheetfb_probe(struct platform_device *dev) > par->read_reg = broadsheet_read_reg; > init_waitqueue_head(&par->waitq); > > - info->flags = FBINFO_FLAG_DEFAULT; > + info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB; > > info->fbdefio = &broadsheetfb_defio; > fb_deferred_io_init(info); > diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c > index 0b4bffb..f9d77ad 100644 > --- a/drivers/video/hecubafb.c > +++ b/drivers/video/hecubafb.c > @@ -253,7 +253,7 @@ static int __devinit hecubafb_probe(struct platform_device *dev) > par->send_command = apollo_send_command; > par->send_data = apollo_send_data; > > - info->flags = FBINFO_FLAG_DEFAULT; > + info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB; > > info->fbdefio = &hecubafb_defio; > fb_deferred_io_init(info); > diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c > index df1f757..661bfd2 100644 > --- a/drivers/video/metronomefb.c > +++ b/drivers/video/metronomefb.c > @@ -700,7 +700,7 @@ static int __devinit metronomefb_probe(struct platform_device *dev) > if (retval < 0) > goto err_free_irq; > > - info->flags = FBINFO_FLAG_DEFAULT; > + info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB; > > info->fbdefio = &metronomefb_defio; > fb_deferred_io_init(info); > -- > 1.6.2.5 > >
Looks good to me. Thanks.
Acked-by: Jaya Kumar <jayakumar.lkml@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |