Messages in this thread | | | Date | Thu, 03 Dec 2009 17:30:50 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 00/86] PATA fixes |
| |
On 12/03/2009 05:23 PM, Bartlomiej Zolnierkiewicz wrote: > On Thursday 03 December 2009 11:10:51 pm Jeff Garzik wrote: >> Is it good kernel practice to intermingle cosmetic changes with >> functional ones, in the same code lines? Also, no. > > I prefer using common sense over black-and-white rules. > > If patch is a _really_ tiny one (< 20 LOC changed) it sometimes makes > sense to save the time on handling separate patches.
This is open source -- you have to consider the time saved by reviewers too.
But I doubt you have saved time on all your motivated commit searches, so...
Jeff
| |