lkml.org 
[lkml]   [2009]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/86] PATA fixes
On 12/03/2009 05:10 PM, Jeff Garzik wrote:
> Did the patch contain -cosmetic- changes intermingled with code changes,
> in the same code lines? No.
>
> Is it good kernel practice to intermingle cosmetic changes with
> functional ones, in the same code lines? Also, no.


In fact, I recall one case where a certain developer on this list used
cosmetic code changes (Lindent, IIRC) to hide functional,
security-related code changes.

Mixing cosmetic and function changes is simply bad engineering practice,
_especially_ when they occur in the same lines of code.

Jeff





\
 
 \ /
  Last update: 2009-12-03 23:25    [W:0.167 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site