Messages in this thread | | | Date | Mon, 28 Dec 2009 09:25:09 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/2] x86/amd-iommu: Fix initialization failure panic |
| |
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> The assumption that acpi_table_parse passes the return value > of the hanlder function to the caller proved wrong > recently. The return value of the handler function is > totally ignored. This makes the initialization code for AMD > IOMMU buggy in a way that could cause a kernel panic on > initialization. This patch fixes the issue in the AMD IOMMU > driver. > > Cc: stable@kernel.org > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> > --- > arch/x86/kernel/amd_iommu_init.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c > index 1dca9c3..fb490ce 100644 > --- a/arch/x86/kernel/amd_iommu_init.c > +++ b/arch/x86/kernel/amd_iommu_init.c > @@ -138,6 +138,11 @@ int amd_iommus_present; > bool amd_iommu_np_cache __read_mostly; > > /* > + * Set to true if ACPI table parsing and hardware intialization went properly > + */ > +static bool amd_iommu_initialized;
Btw., could this new variable be __init?
Ingo
| |