Messages in this thread | | | Date | Mon, 28 Dec 2009 21:52:57 +0100 | From | Pavel Machek <> | Subject | Re: tree with htc dream support |
| |
On Mon 2009-12-28 21:48:48, Pavel Machek wrote: > Hi! > > > >> > Switch smd code to the version in staging. Something to apply to > > >> > dream/ tree I'd say... and yes, it still works. > > >> > > >> I think we might want to consider leaving at least the core smd code > > >> under mach-msm. > > > > > > In the long run, I agree. > > > > > > In the short run... the code is staging quality, so it should be in > > > staging... and you'll not have to mainain so huge diff. (-20 kLoc). > > > > The core smd stuff is really not that large. The central smd.[ch] are > > about 1300 lines, and proc_comm.[ch] are about 400 lines. Is it > > possible to get some review/feedback as to what's "staging quality" > > about this code so we can clean it up? I'd rather just fix the > > issues > > Just submit it to Daniel W., ccing rmk and l-a-k, and I'm sure you'll > get feedback. > > For a start, checkpatch has some mild complains.
BTW if would be cool to fix style in the staging/, then do git mv, so that cleanups are clearly separated/changelogged in kernel proper...
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |