Messages in this thread | | | Date | Mon, 28 Dec 2009 12:35:00 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH] ALSA: test off by one in setsamplerate() |
| |
At Sun, 27 Dec 2009 22:26:47 +0100, Roel Kluin wrote: > > With `while (i++ < MAX_WRITE_RETRY)' i reaches MAX_WRITE_RETRY + 1 after the loop > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied now. Thanks.
Takashi
> --- > sound/pci/riptide/riptide.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c > index b5ca02e..e66ef2b 100644 > --- a/sound/pci/riptide/riptide.c > +++ b/sound/pci/riptide/riptide.c > @@ -1058,7 +1058,7 @@ setsamplerate(struct cmdif *cif, unsigned char *intdec, unsigned int rate) > rptr.retwords[2] != M && > rptr.retwords[3] != N && > i++ < MAX_WRITE_RETRY); > - if (i == MAX_WRITE_RETRY) { > + if (i > MAX_WRITE_RETRY) { > snd_printdd("sent samplerate %d: %d failed\n", > *intdec, rate); > return -EIO; >
| |