Messages in this thread | | | Subject | Re: [PATCH] perf lock: Implement basic sorting function of perf lock | From | Peter Zijlstra <> | Date | Mon, 28 Dec 2009 11:58:18 +0100 |
| |
On Sun, 2009-12-20 at 11:56 +0900, Hitoshi Mitake wrote: > +#define SINGLE_KEY(member) \ > + static int lock_stat_key_ ## member(struct lock_stat *one, \ > + struct lock_stat *two) \ > + { \ > + if (one->member > two->member) \ > + return 1; \ > + else \ > + return 0; \ > + }
Seems to me:
return one->member > two->member;
Should suffice, no?
[ I usually call the arguments to a comparator (l)eft/(r)ight or a/b, but I guess one/two works too :-) ]
| |