lkml.org 
[lkml]   [2009]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo
    Peter Hüwe <PeterHuewe@gmx.de> wrote:
    > Great, thanks for the update.
    > The only thing that still catches my eye is that the kzalloc line can fail, so
    > you should perhaps add something like
    > if (!slave) {
    > printk(KERN_ERR "No memory left for at32ap700x: at32_add_device_mc");
    > goto fail;
    > }

    I agree, except that this is extremely unlikely to happen, so we should
    either drop the printk() or use pr_debug() in order to waste as little
    memory as possible in production systems.

    I think your first patch is good as it is, so I will apply it. Please
    send any additional fixes as a separate patch.

    Haavard
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-28 11:23    [W:0.021 / U:60.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site