lkml.org 
[lkml]   [2009]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/10] perf session: Move full_paths config to symbol_conf
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    Now perf_event_ops has just that, event handlers.

    Cc: Frédéric Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-diff.c | 2 +-
    tools/perf/builtin-report.c | 2 +-
    tools/perf/util/session.c | 2 +-
    tools/perf/util/session.h | 1 -
    tools/perf/util/symbol.h | 3 ++-
    5 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
    index bd71b8c..e164b3d 100644
    --- a/tools/perf/builtin-diff.c
    +++ b/tools/perf/builtin-diff.c
    @@ -204,7 +204,7 @@ static const struct option options[] = {
    OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
    OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules,
    "load module symbols - WARNING: use only with -k and LIVE kernel"),
    - OPT_BOOLEAN('P', "full-paths", &event_ops.full_paths,
    + OPT_BOOLEAN('P', "full-paths", &symbol_conf.full_paths,
    "Don't shorten the pathnames taking into account the cwd"),
    OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
    "only consider symbols in these dsos"),
    diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
    index 0825918..f695084 100644
    --- a/tools/perf/builtin-report.c
    +++ b/tools/perf/builtin-report.c
    @@ -321,7 +321,7 @@ static const struct option options[] = {
    "pretty printing style key: normal raw"),
    OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
    "sort by key(s): pid, comm, dso, symbol, parent"),
    - OPT_BOOLEAN('P', "full-paths", &event_ops.full_paths,
    + OPT_BOOLEAN('P', "full-paths", &symbol_conf.full_paths,
    "Don't shorten the pathnames taking into account the cwd"),
    OPT_STRING('p', "parent", &parent_pattern, "regex",
    "regex filter to identify parent, see: '--sort parent'"),
    diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
    index 4ca427f..4f2eeb5 100644
    --- a/tools/perf/util/session.c
    +++ b/tools/perf/util/session.c
    @@ -306,7 +306,7 @@ int perf_session__process_events(struct perf_session *self,

    head = self->header.data_offset;

    - if (!ops->full_paths) {
    + if (!symbol_conf.full_paths) {
    char bf[PATH_MAX];

    if (getcwd(bf, sizeof(bf)) == NULL) {
    diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h
    index 585937b..2ff77fe 100644
    --- a/tools/perf/util/session.h
    +++ b/tools/perf/util/session.h
    @@ -41,7 +41,6 @@ struct perf_event_ops {
    event_op process_read_event;
    event_op process_throttle_event;
    event_op process_unthrottle_event;
    - bool full_paths;
    };

    struct perf_session *perf_session__new(const char *filename, int mode, bool force);
    diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
    index 8aded23..9eabd60 100644
    --- a/tools/perf/util/symbol.h
    +++ b/tools/perf/util/symbol.h
    @@ -58,7 +58,8 @@ struct symbol_conf {
    sort_by_name,
    show_nr_samples,
    use_callchain,
    - exclude_other;
    + exclude_other,
    + full_paths;
    const char *vmlinux_name,
    *field_sep;
    char *dso_list_str,
    --
    1.6.2.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-28 00:39    [W:0.031 / U:31.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site