Messages in this thread | | | Date | Thu, 24 Dec 2009 07:53:57 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] scripts/get_maintainer.pl: add support to read patch from STDIN |
| |
On Thu, Dec 24, 2009 at 07:45:56AM +0100, Borislav Petkov wrote: > On Wed, Dec 23, 2009 at 03:27:04PM -0800, Joe Perches wrote: > > On Wed, 2009-12-23 at 14:55 +0100, Borislav Petkov wrote: > > > Teach get_maintainer.pl to read a diff from STDIN > > > > How about this instead? > > > > Doesn't need or accept '-' as a trailing option to read stdin. > > Doesn't print usage() after bad options. > > Adds --usage as command line equivalent of --help > > This breaks current usage and possibly other scripts: > > # git diff | ./scripts/get_maintainer.pl - > ./scripts/get_maintainer.pl: file '-' not found
Sorry, too early here. What I meant was that it should be able to receive both '-' and simply piped input (i.e., without '-'):
git diff | ./scripts/get_maintainer.pl -
as well as
git diff | ./scripts/get_maintainer.pl
IMO.
-- Regards/Gruss, Boris.
| |