Messages in this thread | | | Date | Wed, 23 Dec 2009 21:54:48 -0800 (PST) | Subject | Re: [PATCH] net/via-rhine: Fix scheduling while atomic bugs | From | David Miller <> |
| |
From: Jarek Poplawski <jarkao2@gmail.com> Date: Tue, 22 Dec 2009 18:36:42 +0100
> There are BUGs "scheduling while atomic" triggered by the timer > rhine_tx_timeout(). They are caused by calling napi_disable() (with > msleep()). This patch fixes it by moving most of the timer content to > the workqueue function (similarly to other drivers, like tg3), with > spin_lock() changed to BH version. > > Additionally, there is spin_lock_irq() moved in rhine_close() to > exclude napi_disable() etc., also tg3's way. > > Reported-by: Andrey Rahmatullin <wrar@altlinux.org> > Tested-by: Andrey Rahmatullin <wrar@altlinux.org> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied, thanks!
| |