lkml.org 
[lkml]   [2009]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] prctl: return MCE process flags through pointer
On Tue, Dec 22, 2009 at 05:34:24PM -0800, Andrew Morton wrote:
> On Wed, 23 Dec 2009 02:14:51 +0100 Andi Kleen <andi@firstfloor.org> wrote:
>
> > "Smith, GeoffX" <geoffx.smith@intel.com> writes:
> >
> > > This patch fixes the semantics of prctl() option PR_MCE_KILL_GET
> > > to pass the return value through *arg2.
> > >
> > > With this change, the option now follows the same conventions as the
> > > other "get" options added since 2.6.0, and also brings it into
> > > conformance with the advice in chapter 16 of Documentation/CodingStyle.
> > >
> > > This prctl() option was only added within the last month, so there are
> > > not any production applications to break. This patch applies cleanly
> > > to mainline and to 2.6.32.2 for backporting.
> >
> > It breaks the test suite, the man pages, qemu and one slide deck at least.
> >
>
> Should've got it right the first time.

To be honest it's not fully clear to me what is "wrong" with returning
the return value with "return".

If there was a security bug or something maybe such a radical step
as changing a published API would be justified, but for this I'm sceptical.

>
> What goes wrong with qemu?

It's the main current user of this interface currently.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2009-12-23 10:55    [from the cache]
©2003-2011 Jasper Spaans