Messages in this thread | | | Date | Tue, 22 Dec 2009 10:39:56 -0500 | From | Jason Baron <> | Subject | Re: [RFC PATCH] dynamic debug - adding ring buffer storage support |
| |
On Tue, Dec 22, 2009 at 12:32:06PM +0100, Jiri Olsa wrote: > Hi, > > as I use dynamic debug sometimes, I thought it could be useful having > the possibility to store the output somewhere else than dmesg. > > The attached patch implements support for storing dynamic debug > messages to the ring buffer. > > The dynamic debug allows simple addition of new flags, > so I added 'r' flag for ring buffer storage. > > I used the ring buffer implementation from trace framework. > > hopefuly this could be any use for others as well... > plz let me know what you think, > > jirka >
hi,
I like the idea of using the ring buffer for output. However, I'm not sure why we need a separate one for this. I like adding the 'r' for ring buffer storage, by why not just make this path call 'trace_printk()', and store the string in the existing kernel tracing ring buffer? That way it can interleave with other trace data as well.
thanks,
-Jason
| |