Messages in this thread Patch in this message | | | Date | Mon, 21 Dec 2009 19:58:58 +0800 | From | Liuwenyi <> | Subject | [PATCHv2 07/12]posix_acl: Add the check items |
| |
move the ACL validation check in to fs/posix_acl.c. Including nullpointer check and PTR_ERR check.
--- Signed-off-by: Liuwenyi <qingshenlwy@gmail.com> Cc: Steven Whitehouse <swhiteho@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Joel Becker <joel.becker@oracle.com> Cc: James Morris <jmorris@namei.org> Cc: Christoph Hellwig <hch@lst.de> Cc: cluster-devel@redhat.com Cc: linux-kernel@vger.kernel.org
--- diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c index 87ee309..462f4e3 100644 --- a/fs/gfs2/acl.c +++ b/fs/gfs2/acl.c @@ -284,17 +284,6 @@ static int gfs2_xattr_system_set(struct dentry *dentry, const char *name, goto set_acl;
acl = posix_acl_from_xattr(value, size); - if (!acl) { - /* - * acl_set_file(3) may request that we set default ACLs with - * zero length -- defend (gracefully) against that here. - */ - goto out; - } - if (IS_ERR(acl)) { - error = PTR_ERR(acl); - goto out; - }
error = posix_acl_valid(acl); if (error)
-- Best Regards, Liuwenyi
| |