lkml.org 
[lkml]   [2009]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kbuild: correct size calculation of bzImgae / fix x86 boot
    On Sun, Dec 20, 2009 at 11:03:44AM +0100, Sam Ravnborg wrote:
    > We use ... printf \x ... when calculating the size of the
    > compressed kernel.
    > Unfortunately dash built-in printf does not support this notation
    > resulting in a non-bootable kernel.
    >
    > Fix this by always using the external version of printf.

    Do we really want to workaround shells bugs ? I mean, either
    the shell correctly implements the printf function or it does
    not at all so that the correct printf is found in the path.
    "man printf" clearly states that \x is supported, so what
    should be fixed is the shell's implementation of printf.

    The more absolute paths we specify, the less portable the
    build system. And if linking /bin/sh to whatever shell works
    but linking it to dash breaks, it's a shell bug.

    Willy



    \
     
     \ /
      Last update: 2009-12-20 11:33    [W:0.222 / U:0.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site