lkml.org 
[lkml]   [2009]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [1/2] SYSCTL: Make bin_table not const
Andi Kleen <andi@firstfloor.org> writes:

> On Sat, Dec 19, 2009 at 09:40:56AM -0800, Linus Torvalds wrote:
>>
>>
>> On Sat, 19 Dec 2009, Andi Kleen wrote:
>> >
>> > Turn all the bin_tables from const to non-const. This is needed for the next
>> > patch. Unfortunately there were a lot of them, so the patch is rather
>> > large, but it is completely mechanic.
>>
>> Ouch. I hate this.
>>
>> I'd much rather have a constant sysctl bin_table.
>
> Understood. I'll poke at that and try to come up with a tested patch
> tomorrow or so.

Is printk_ratelimit truly ineffective at what it does?

Arguably we don't need to warn anywhere near that often, so even
if printk_ratelimit works we are good.

If printk_ratelimit let's too much through we really should also write
a patch to let fewer messages through that way.

Eric


\
 
 \ /
  Last update: 2009-12-20 21:09    [W:0.061 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site