Messages in this thread Patch in this message | | | Date | Wed, 02 Dec 2009 10:17:44 -0500 | From | Casey Dahlin <> | Subject | [PATCH] [SCSI] megaraid_sas: remove sysfs dbg_lvl world writeable permissions |
| |
From: Bryn M. Reeves <bmr@redhat.com>
/sys/bus/pci/drivers/megaraid_sas/poll_mode_io defaults to being world-writable, which seems bad (letting any user affect kernel driver behavior).
This turns off group and user write permissions, so that on typical production systems only root can write to it.
Signed-off-by: Bryn M. Reeves <bmr@redhat.com> Signed-off-by: Casey Dahlin <cdahlin@redhat.com> --- drivers/scsi/megaraid/megaraid_sas.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c index a39addc..08a7f49 100644 --- a/drivers/scsi/megaraid/megaraid_sas.c +++ b/drivers/scsi/megaraid/megaraid_sas.c @@ -3451,7 +3451,7 @@ out: return retval; } -static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUGO, +static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUSR, megasas_sysfs_show_poll_mode_io, megasas_sysfs_set_poll_mode_io); -- 1.6.2.5
| |