lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Q, slab, kmemleak_erase() and redzone?
Date

Pekka Enberg:
> > No, you are absolutely correct. Can you please send an updated patch to
> > Catalin that adds a comment on top of the cpu_cache_get() call that
> > explains why we need it there?
>
> Doh, this was supposed to be a reply to Okajima's email :-).

Before I send a small patch, let me make sure about other small issues.

- How heavy is 'ac = cpu_cache_get(cachep)' (which will be inserted by
the patch)?
It will be compiled and executed regardless CONFIG_DEBUG_KMEMLEAK, and
it is totally meaningless when DEBUG_KMEMLEAK is disabled. Can we
ignore this loss?

- Should we add a condition 'if (objp)' before calling kmemleak_erase()?
As Catalin wrote, it may be harmless. But setting NULL is unnecessary.
Do you accept this change too?


J. R. Okajima


\
 
 \ /
  Last update: 2009-12-02 07:59    [W:0.036 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site