Messages in this thread | | | Date | Wed, 2 Dec 2009 18:59:03 +0000 | From | Alan Cox <> | Subject | Re: [PATCH 06/11] pps: serial clients support. |
| |
On Wed, 2 Dec 2009 18:18:44 +0100 Rodolfo Giometti <giometti@linux.it> wrote:
> Adds support, by using the PPS line discipline, for the PPS sources > connected with the CD (Carrier Detect) pin of a serial port.
I would suggest one change here - but the pps-ldisc bits into the n_tty.c file then you don't have to export everything. That or just export the n_tty ops struct.
I think putting the pps ldisc (which is basically n_tty and a bit) into n_tty is probably the right choice given how small and clean it is - what do you think ?
| |