Messages in this thread | | | Date | Wed, 2 Dec 2009 15:05:33 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init() |
| |
On 12/01, Veaceslav Falico wrote: > > Remove unneeded initializations in acct_init_pacct() and taskstats_tgid_init(). > These are accessed only via copy_signal(). > > Signed-off-by: Veaceslav Falico <vfalico@redhat.com> > --- > > diff --git a/include/linux/taskstats_kern.h b/include/linux/taskstats_kern.h > index 3398f45..d66167a 100644 > --- a/include/linux/taskstats_kern.h > +++ b/include/linux/taskstats_kern.h > @@ -16,7 +16,6 @@ extern struct mutex taskstats_exit_mutex; > > static inline void taskstats_tgid_init(struct signal_struct *sig) > { > - sig->stats = NULL; > } > > static inline void taskstats_tgid_free(struct signal_struct *sig) > diff --git a/kernel/acct.c b/kernel/acct.c > index 9a4715a..8909c26 100644 > --- a/kernel/acct.c > +++ b/kernel/acct.c > @@ -592,8 +592,6 @@ out: > */ > void acct_init_pacct(struct pacct_struct *pacct) > { > - memset(pacct, 0, sizeof(struct pacct_struct)); > - pacct->ac_utime = pacct->ac_stime = cputime_zero; > }
Looks good imho. But please note that with this patch both taskstats_tgid_init() and acct_init_pacct() become empty, and we already have "empty" definitions for #ifndef case.
Perhaps it makes sense to move this (now empty) helper outside of #ifdef, or just kill it.
Up to maintainres.
Oleg.
| |