lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch] thinkpad_acpi: fix a build error
    At Fri, 18 Dec 2009 17:42:34 +0800,
    Xiaotian Feng wrote:
    >
    > Ingo already sent this patch yesterday.
    > http://lkml.org/lkml/2009/12/17/25
    >
    >
    > On Fri, Dec 18, 2009 at 5:28 PM, Amerigo Wang <amwang@redhat.com> wrote:
    > >
    > > This patch fixes the following build error:
    > >
    > >  Building modules, stage 2.
    > >  MODPOST 1834 modules
    > > ERROR: "snd_card_create" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
    > > ERROR: "snd_ctl_notify" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
    > > ERROR: "snd_ctl_boolean_mono_info" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
    > > ERROR: "snd_ctl_new1" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
    > > ERROR: "snd_card_free" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
    > > ERROR: "snd_card_register" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
    > > ERROR: "snd_ctl_add" [drivers/platform/x86/thinkpad_acpi.ko] undefined!
    > >
    > > Cc: Len Brown <len.brown@intel.com>
    > > Cc: Corentin Chary <corentincj@iksaif.net>
    > > Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
    > > Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
    > > Reported-by: Helight.Xu <helight.xu@gmail.com>
    > > Signed-off-by: WANG Cong <amwang@redhat.com>
    > > Tested-by: Helight.Xu <helight.xu@gmail.com>
    > >
    > > ---
    > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
    > > index fc5bf9d..596966c 100644
    > > --- a/drivers/platform/x86/Kconfig
    > > +++ b/drivers/platform/x86/Kconfig
    > > @@ -215,6 +215,7 @@ config THINKPAD_ACPI
    > >        depends on ACPI
    > >        depends on INPUT
    > >        depends on RFKILL || RFKILL = n
    > > +       depends on SOUND

    The patch isn't correct (I guess the upstream fix is same?).

    CONFIG_SOUND is a global config for sound subsystem. The relevant
    functions are ALSA core part, which is CONFIG_SND.
    So, the fix should be:

    depends on SND

    instead.


    Takashi
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-18 11:17    [W:0.034 / U:125.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site