lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/7] can/at91: don't check platform_get_irq's return value against zero
    From
    From: Wolfgang Grandegger <wg@grandegger.com>
    Date: Wed, 16 Dec 2009 19:58:38 +0100

    > Uwe Kleine-König wrote:
    >> platform_get_irq returns -ENXIO on failure, so !irq was probably
    >> always true. Better use (int)irq <= 0. Note that a return value of
    >> zero is still handled as error even though this could mean irq0.
    >>
    >> This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
    >> changed the return value of platform_get_irq from 0 to -ENXIO on error.
    >>
    >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    >
    > Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>

    Applied, thanks.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-19 05:35    [W:0.020 / U:1.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site