lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars
    From
    Date
    On Thu, 2009-12-17 at 23:29 -0500, Valdis.Kletnieks@vt.edu wrote:
    > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
    > continuation line, it's probably in its rights to whinge.
    > grep -r -P '^\t{7:}(?!(.*,$|.*\);$))' . | more
    > produces a whole lot of "this can't end well" output.

    I think this is a good test to add to checkpatch.

    Add 105 character long line WARN test
    Add 80 character long line STRICT test
    Add 6+ leading indent tabs test, consider restructuring

    Signed-off-by: Joe Perches <joe@perches.com>

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index bc4114f..c358251 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -1374,13 +1374,20 @@ sub process {
    # check we are in a valid source file if not then ignore this hunk
    next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);

    -#80 column limit
    +#Line too long
    if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
    $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
    - $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
    - $length > 80)
    - {
    - WARN("line over 80 characters\n" . $herecurr);
    + $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/) {
    + if ($length > 105) {
    + WARN("line over 105 characters\n" . $herecurr);
    + } elsif ($length > 80) {
    + CHK("line over 80 characters\n" . $herecurr);
    + }
    + }
    +
    +#too many leading tabs - deep leading indent
    + if ($line =~ /^\+ {6,}(?!(.*,$|.*\);$))/) {
    + CHK("Too many leading tabs. Consider restructuring code\n" . $herecurr);
    }

    # check for adding lines without a newline.



    \
     
     \ /
      Last update: 2009-12-18 06:15    [W:0.019 / U:29.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site